Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update the flowschema api version from v1beta3 to v1 #7500

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

hustshawn
Copy link
Contributor

@hustshawn hustshawn commented Dec 9, 2024

Fixes #N/A

Description

FlowControl API moved to v1 since v1.29, and will be removed till v1.32. reference

To remediate the issue comes from upgrade insights report

Migrate manifests and API clients to use the flowcontrol.apiserver.k8s.io/v1 API version, available since v1.29

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hustshawn hustshawn requested a review from a team as a code owner December 9, 2024 08:16
@hustshawn hustshawn requested a review from ellistarn December 9, 2024 08:16
Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 6402a2a
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6757de798aef7f0008c3fd2c
😎 Deploy Preview https://deploy-preview-7500--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12231539558

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 65.022%

Totals Coverage Status
Change from base Build 12188736413: 0.0%
Covered Lines: 5733
Relevant Lines: 8817

💛 - Coveralls

jonathan-innis
jonathan-innis previously approved these changes Dec 10, 2024
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis enabled auto-merge (squash) December 10, 2024 06:24
@jonathan-innis jonathan-innis merged commit f4f0029 into aws:main Dec 10, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants