Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update CRD note in upgrade guide #7473

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Dec 2, 2024

Fixes #N/A

Description
Updates the CRD upgrade description to emphasize the link between CRD version and provider version, and codifies the recommendation to use the independent CRD chart.

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner December 2, 2024 18:35
@jmdeal jmdeal requested a review from edibble21 December 2, 2024 18:35
Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 1f8571a
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/674e060a0b3faf00089c25f6
😎 Deploy Preview https://deploy-preview-7473--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Dec 2, 2024

Pull Request Test Coverage Report for Build 12126268841

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 65.022%

Totals Coverage Status
Change from base Build 12100336304: 0.0%
Covered Lines: 5733
Relevant Lines: 8817

💛 - Coveralls

jonathan-innis
jonathan-innis previously approved these changes Dec 2, 2024
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jmdeal jmdeal force-pushed the docs/update-crd-note branch 2 times, most recently from f3237bc to deceada Compare December 2, 2024 19:08
@jmdeal jmdeal force-pushed the docs/update-crd-note branch from deceada to 1f8571a Compare December 2, 2024 19:10
@jmdeal jmdeal enabled auto-merge (squash) December 2, 2024 19:21
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jmdeal jmdeal merged commit ea09fdc into aws:main Dec 3, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants