Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable setting schedulerName in Helm chart #7456

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

robinkb
Copy link
Contributor

@robinkb robinkb commented Nov 28, 2024

Fixes #7455

Description

Enables setting schedulerName on the Karpenter to pod to support specifying a custom scheduler.

How was this change tested?

$ helm template charts/karpenter --show-only templates/deployment.yaml
# Verified that the template contains `schedulerName: "default-scheduler"`
$ template charts/karpenter --show-only templates/deployment.yaml --set schedulerName=fargate-scheduler
# Verified that the template contains `schedulerName: "fargate-scheduler"`

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

It kinda does impact documentation, namely the Helm chart README. But it appears that the Helm chart README is not up-to-date, as running helm-docs includes changes that are not caused by my PR.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@robinkb robinkb requested a review from a team as a code owner November 28, 2024 07:23
@robinkb robinkb requested a review from edibble21 November 28, 2024 07:23
Copy link

netlify bot commented Nov 28, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 27b90e6
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/67481bfd9064100008fa31c6

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-27b90e60ea2e61de0ae566488d7baf4f163f3e31.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-27b90e60ea2e61de0ae566488d7baf4f163f3e31" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12064383487

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 65.022%

Totals Coverage Status
Change from base Build 12037582983: 0.0%
Covered Lines: 5733
Relevant Lines: 8817

💛 - Coveralls

@jonathan-innis jonathan-innis merged commit 4ad80a5 into aws:main Dec 5, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable specifying a custom scheduler for Karpenter pods
3 participants