Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: handle observed generation change in operatorpkg #7415

Closed
wants to merge 1 commit into from

Conversation

rschalo
Copy link
Contributor

@rschalo rschalo commented Nov 20, 2024

Fixes #N/A

Description
Adds requeueing to sub-reconcilers if a status Set() call returns false because of an observed generation mismatch.

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rschalo rschalo requested a review from a team as a code owner November 20, 2024 18:25
@rschalo rschalo requested a review from jmdeal November 20, 2024 18:25
Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 9ab7cc8
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/673e29a57e78e50008ea2c02

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11939470466

Details

  • 4 of 15 (26.67%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 82.341%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/nodeclass/status/instanceprofile.go 1 3 33.33%
pkg/controllers/nodeclass/status/securitygroup.go 1 3 33.33%
pkg/controllers/nodeclass/status/subnet.go 1 3 33.33%
pkg/controllers/nodeclass/status/ami.go 1 6 16.67%
Totals Coverage Status
Change from base Build 11924046371: -0.1%
Covered Lines: 5684
Relevant Lines: 6903

💛 - Coveralls

@rschalo rschalo closed this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants