Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add node metrics controller #734

Merged
merged 11 commits into from
Oct 6, 2021
Merged

add node metrics controller #734

merged 11 commits into from
Oct 6, 2021

Conversation

cjerad
Copy link
Contributor

@cjerad cjerad commented Oct 5, 2021

1. Issue, if available:
#612 "Emit Metrics for Karpenter"

This PR does not fully resolve the issue. More changes will be needed.

2. Description of changes:
Add a controller that runs periodically, and in response to some provisioner events, and publishes different counts of nodes broken out by zone, instance-type, etc.

3. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Oct 5, 2021

✔️ Deploy Preview for karpenter-docs-prod canceled.

🔨 Explore the source changes: ec0513a

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/615de8c5da33a600087b1fd3

@bwagner5 bwagner5 self-requested a review October 5, 2021 19:41
pkg/controllers/metrics/node/controller.go Outdated Show resolved Hide resolved
pkg/controllers/metrics/node/counter.go Outdated Show resolved Hide resolved
pkg/controllers/metrics/node/counter.go Outdated Show resolved Hide resolved
pkg/controllers/metrics/node/counter.go Outdated Show resolved Hide resolved
pkg/controllers/metrics/node/counter.go Show resolved Hide resolved
pkg/controllers/metrics/node/controller.go Outdated Show resolved Hide resolved
pkg/controllers/metrics/node/counter.go Outdated Show resolved Hide resolved
pkg/controllers/metrics/node/controller.go Outdated Show resolved Hide resolved
pkg/controllers/metrics/node/controller.go Outdated Show resolved Hide resolved
pkg/controllers/metrics/node/counter.go Outdated Show resolved Hide resolved
pkg/controllers/metrics/node/counter.go Outdated Show resolved Hide resolved
pkg/controllers/metrics/node/counter.go Outdated Show resolved Hide resolved
JacobGabrielson
JacobGabrielson previously approved these changes Oct 6, 2021
Copy link
Contributor

@JacobGabrielson JacobGabrielson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few minor optional comments, lgtm

Thanks!!!

@cjerad cjerad merged commit 6fe5407 into aws:main Oct 6, 2021
@cjerad cjerad deleted the metrics-node-count2 branch October 6, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants