Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: invalidate SSM cache upon AMI deprecation (#7301) #7313

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Nov 1, 2024

Fixes #N/A

Description
Backports #7301 to the v1 release branch.

How was this change tested?
make test

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner November 1, 2024 20:45
@jmdeal jmdeal requested a review from njtran November 1, 2024 20:45
@coveralls
Copy link

coveralls commented Nov 1, 2024

Pull Request Test Coverage Report for Build 11708944369

Details

  • 114 of 144 (79.17%) changed or added relevant lines in 14 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.09%) to 79.285%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/controllers.go 0 2 0.0%
pkg/providers/amifamily/ami.go 15 17 88.24%
pkg/apis/v1/ec2nodeclass.go 15 18 83.33%
pkg/operator/operator.go 0 5 0.0%
pkg/controllers/providers/ssm/invalidation/controller.go 35 43 81.4%
pkg/apis/v1/zz_generated.deepcopy.go 0 10 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.91%
Totals Coverage Status
Change from base Build 11620447635: -0.09%
Covered Lines: 6032
Relevant Lines: 7608

💛 - Coveralls

pkg/apis/v1/ec2nodeclass_conversion.go Outdated Show resolved Hide resolved
pkg/providers/amifamily/types.go Show resolved Hide resolved
pkg/test/environment.go Outdated Show resolved Hide resolved
Copy link
Contributor

@rschalo rschalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmdeal jmdeal enabled auto-merge (squash) November 6, 2024 21:22
@jmdeal jmdeal merged commit a2875e3 into aws:release-v1.0.x Nov 6, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants