Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly check for latest alias #7302

Merged
merged 1 commit into from
Oct 31, 2024
Merged

fix: correctly check for latest alias #7302

merged 1 commit into from
Oct 31, 2024
+6 −3

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Oct 30, 2024

Fixes #N/A

Description
Corrects the check for latest alias when determining if we should discover deprecated AMI.

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner October 30, 2024 19:39
@jmdeal jmdeal requested a review from engedaam October 30, 2024 19:39
@coveralls
Copy link

coveralls commented Oct 30, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11601688552

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 79.364%
Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 91.97%
pkg/fake/utils.go 2 94.56%
Totals Coverage Status
Change from base Build 11469429666: -0.03%
Covered Lines: 5961
Relevant Lines: 7511
💛 - Coveralls

jonathan-innis
jonathan-innis previously approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

pkg/providers/amifamily/ami.go Show resolved Hide resolved
jonathan-innis
jonathan-innis approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jmdeal jmdeal merged commit fdab296 into aws:release-v1.0.x Oct 31, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@engedaam engedaam Awaiting requested review from engedaam engedaam is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmdeal @coveralls @jonathan-innis