Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(0.33.x): discover deprecated EKS optimized AMIs #7247

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Oct 18, 2024

Fixes #N/A

Description
In the event of an AMI deprecation, we may not discover the new SSM parameter for up to 24 hours. Rather than failing to provision for those 24 hours, we'll continue to discover and use the deprecated AMI. This only impacts those using Karpetner's automatic AMI upgrade system which is not meant for production workloads.

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

In the event of an AMI deprecation, we may not discover the new SSM
parameter for up to 24 hours. Rather than failing to provision for those
24 hours, we'll continue to discover and use the deprecated AMI. This
only impacts those using Karpetner's automatic AMI upgrade system which
is not meant for production workloads.
@jmdeal jmdeal requested a review from a team as a code owner October 18, 2024 01:14
@jmdeal jmdeal requested a review from bwagner5 October 18, 2024 01:14
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11395648576

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 77.815%

Totals Coverage Status
Change from base Build 11356051253: 0.02%
Covered Lines: 5349
Relevant Lines: 6874

💛 - Coveralls

Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jmdeal jmdeal merged commit 7e8585e into aws:release-v0.33.x Oct 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants