Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase node liveness timeout to 15 min #724

Merged
merged 2 commits into from
Oct 1, 2021

Conversation

bwagner5
Copy link
Contributor

@bwagner5 bwagner5 commented Oct 1, 2021

1. Issue, if available:
N/A

2. Description of changes:

  • Output userdata script to EC2 Console for easier debugging
  • Up the node liveness timeout from 5 to 15 mins to account for custom LTs that take longer to bootstrap (like when using the default kops LT).

3. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Oct 1, 2021

✔️ Deploy Preview for karpenter-docs-prod canceled.

🔨 Explore the source changes: 27eaa6c

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/61573ca70bc05600077ee8c3

@bwagner5 bwagner5 changed the title Liveness and debug Up node liveness timeout to 15 min Oct 1, 2021
@bwagner5 bwagner5 changed the title Up node liveness timeout to 15 min Increase node liveness timeout to 15 min Oct 1, 2021
@@ -28,7 +28,7 @@ import (
"sigs.k8s.io/controller-runtime/pkg/reconcile"
)

const LivenessTimeout = 5 * time.Minute
const LivenessTimeout = 15 * time.Minute
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We seriously need to replace this with limits.

@bwagner5 bwagner5 merged commit 00c1728 into aws:main Oct 1, 2021
@bwagner5 bwagner5 deleted the liveness-and-debug branch October 1, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants