Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Backport webhook smoke test v0.34.x #7227

Merged
merged 7 commits into from
Oct 15, 2024
Merged

fix: Backport webhook smoke test v0.34.x #7227

merged 7 commits into from
Oct 15, 2024

Conversation

rschalo
Copy link
Contributor

@rschalo rschalo commented Oct 15, 2024

Fixes #N/A

Description
Backports webhook smoke tests

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rschalo rschalo requested a review from a team as a code owner October 15, 2024 21:27
@rschalo rschalo requested a review from danxwang22 October 15, 2024 21:27
@coveralls
Copy link

coveralls commented Oct 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11355479978

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 77.922%
Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.37%
Totals Coverage Status
Change from base Build 11184862837: -0.02%
Covered Lines: 5446
Relevant Lines: 6989
💛 - Coveralls

jmdeal
jmdeal approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rschalo rschalo merged commit 4413d6a into aws:release-v0.34.x Oct 15, 2024
12 checks passed
@rschalo rschalo deleted the backport-webhook-smoke-test-34 branch October 15, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmdeal jmdeal jmdeal approved these changes

@danxwang22 danxwang22 Awaiting requested review from danxwang22 danxwang22 is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rschalo @coveralls @jmdeal