Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(0.37.x): disable webhooks appropriately in chart #7177

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Oct 7, 2024

Fixes #N/A

Description
Updates the logic to disable the helm chart in the Karpenter deployment to reflect the new default upstream when the environment variable isn't set.

How was this change tested?
Applying Karpenter with the updated helm chart with webhooks disabled.

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner October 7, 2024 19:36
@jmdeal jmdeal requested a review from engedaam October 7, 2024 19:36
@coveralls
Copy link

coveralls commented Oct 7, 2024

Pull Request Test Coverage Report for Build 11297193859

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 78.678%

Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.5%
Totals Coverage Status
Change from base Build 11278719400: -0.01%
Covered Lines: 5893
Relevant Lines: 7490

💛 - Coveralls

@jmdeal jmdeal force-pushed the fix/0.37.x-webhook-chart branch from 31c9ef1 to fb28787 Compare October 7, 2024 20:52
@jmdeal jmdeal force-pushed the fix/0.37.x-webhook-chart branch from fb28787 to 7d6d1cd Compare October 11, 2024 18:07
Copy link
Contributor

@rschalo rschalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rschalo rschalo merged commit e0f0072 into aws:release-v0.37.x Oct 15, 2024
14 checks passed
jmdeal added a commit to jmdeal/karpenter-provider-aws that referenced this pull request Oct 15, 2024
jmdeal added a commit to jmdeal/karpenter-provider-aws that referenced this pull request Oct 15, 2024
jmdeal added a commit to jmdeal/karpenter-provider-aws that referenced this pull request Oct 15, 2024
jmdeal added a commit to jmdeal/karpenter-provider-aws that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants