-
Notifications
You must be signed in to change notification settings - Fork 979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(0.37.x): disable webhooks appropriately in chart #7177
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11297193859Details
💛 - Coveralls |
jmdeal
force-pushed
the
fix/0.37.x-webhook-chart
branch
from
October 7, 2024 20:52
31c9ef1
to
fb28787
Compare
jmdeal
force-pushed
the
fix/0.37.x-webhook-chart
branch
from
October 11, 2024 18:07
fb28787
to
7d6d1cd
Compare
rschalo
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jmdeal
added a commit
to jmdeal/karpenter-provider-aws
that referenced
this pull request
Oct 15, 2024
jmdeal
added a commit
to jmdeal/karpenter-provider-aws
that referenced
this pull request
Oct 15, 2024
jmdeal
added a commit
to jmdeal/karpenter-provider-aws
that referenced
this pull request
Oct 15, 2024
jmdeal
added a commit
to jmdeal/karpenter-provider-aws
that referenced
this pull request
Oct 15, 2024
This was referenced Oct 15, 2024
jmdeal
added a commit
that referenced
this pull request
Oct 15, 2024
jmdeal
added a commit
that referenced
this pull request
Oct 15, 2024
jmdeal
added a commit
that referenced
this pull request
Oct 15, 2024
jmdeal
added a commit
that referenced
this pull request
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Description
Updates the logic to disable the helm chart in the Karpenter deployment to reflect the new default upstream when the environment variable isn't set.
How was this change tested?
Applying Karpenter with the updated helm chart with webhooks disabled.
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.