Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: wait for node intialization in zone-id tests #7159

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Oct 4, 2024

Fixes #N/A

Description

Wait for the Node's to be initialized in the zone-id scheduling tests before inspecting labels. This fix was already taken into main: #6493

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner October 4, 2024 17:45
@jmdeal jmdeal requested a review from njtran October 4, 2024 17:45
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11184529714

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.04%) to 78.678%

Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.5%
pkg/fake/utils.go 2 94.56%
Totals Coverage Status
Change from base Build 11171290564: -0.04%
Covered Lines: 5893
Relevant Lines: 7490

💛 - Coveralls

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jmdeal jmdeal merged commit f587167 into aws:release-v0.37.x Oct 4, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants