Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: gpu label test v0.37.x #7156

Merged
merged 1 commit into from
Oct 3, 2024
Merged

fix: gpu label test v0.37.x #7156

merged 1 commit into from
Oct 3, 2024

Conversation

rschalo
Copy link
Contributor

@rschalo rschalo commented Oct 3, 2024

Fixes #N/A

Description
Addresses test failure by pinning AMI

How was this change tested?
Make e2etests

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rschalo rschalo requested a review from a team as a code owner October 3, 2024 23:16
@rschalo rschalo requested a review from bwagner5 October 3, 2024 23:16
jmdeal
jmdeal approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rschalo rschalo enabled auto-merge (squash) October 3, 2024 23:20
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11171157807

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.04%) to 78.678%
Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.5%
pkg/fake/utils.go 2 94.56%
Totals Coverage Status
Change from base Build 11135984891: -0.04%
Covered Lines: 5893
Relevant Lines: 7490
💛 - Coveralls

@rschalo rschalo merged commit 7397a62 into aws:release-v0.37.x Oct 3, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmdeal jmdeal jmdeal approved these changes

@bwagner5 bwagner5 Awaiting requested review from bwagner5 bwagner5 is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rschalo @coveralls @jmdeal