Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix docgen failures #7142

Merged
merged 1 commit into from
Oct 1, 2024
Merged

chore: Fix docgen failures #7142

merged 1 commit into from
Oct 1, 2024

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Oct 1, 2024 •
edited
Loading

Fixes #N/A

Description

Fix make docgen failure on main

How was this change tested?

make presubmit
make docgen

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis marked this pull request as ready for review October 1, 2024 21:24
@jonathan-innis jonathan-innis requested a review from a team as a code owner October 1, 2024 21:24
@jonathan-innis jonathan-innis enabled auto-merge (squash) October 1, 2024 21:24
@coveralls
Copy link

coveralls commented Oct 1, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11134019960

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.326%
Totals Coverage Status
Change from base Build 11133454619: 0.0%
Covered Lines: 5572
Relevant Lines: 6687
💛 - Coveralls

jigisha620
jigisha620 approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@jigisha620 jigisha620 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis reopened this Oct 1, 2024
@jonathan-innis jonathan-innis enabled auto-merge (squash) October 1, 2024 21:50
@jonathan-innis jonathan-innis merged commit 2da6767 into aws:main Oct 1, 2024
24 checks passed
@netlify Netlify
Copy link

netlify bot commented Oct 1, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit a69a2e0
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66fc688102b989000815cb1c

rschalo pushed a commit to rschalo/karpenter-provider-aws that referenced this pull request Oct 1, 2024
@jonathan-innis @rschalo
chore: Fix docgen failures (aws#7142)
66059a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jigisha620 jigisha620 jigisha620 approved these changes

@bwagner5 bwagner5 Awaiting requested review from bwagner5 bwagner5 is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathan-innis @coveralls @jigisha620