Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instance Profile V2 Migration #7096

Closed
wants to merge 3 commits into from
Closed

Conversation

edibble21
Copy link
Contributor

@edibble21 edibble21 commented Sep 27, 2024

Fixes #N/A

Description
Migrated Instance Profile Provider V2 Migration and updated tests.
How was this change tested?
make presubmit
make test
make ci-test
Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

netlify bot commented Sep 27, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit ef81aa2
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66f71e800f1c970008d564df

@coveralls
Copy link

coveralls commented Sep 27, 2024

Pull Request Test Coverage Report for Build 11077711774

Details

  • 58 of 154 (37.66%) changed or added relevant lines in 4 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-1.0%) to 82.03%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/providers/instanceprofile/instanceprofile.go 17 20 85.0%
pkg/errors/errors.go 10 14 71.43%
pkg/operator/operator.go 0 34 0.0%
pkg/fake/iamapi.go 31 86 36.05%
Files with Coverage Reduction New Missed Lines %
pkg/errors/errors.go 4 55.56%
pkg/fake/iamapi.go 4 58.74%
Totals Coverage Status
Change from base Build 11077084057: -1.0%
Covered Lines: 5569
Relevant Lines: 6789

💛 - Coveralls

@edibble21 edibble21 changed the title V2 migration Instance Profile V2 Migration Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants