Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add optional mutator to instancetype provider #7095

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Sep 27, 2024

Fixes #N/A

Description
Adds an optional mutator to the instance profile provider, allowing up-the-tree mutations without additional locking

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner September 27, 2024 18:21
@jmdeal jmdeal requested a review from engedaam September 27, 2024 18:21
Copy link

netlify bot commented Sep 27, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit ab4e7cf
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66f70fa62803bc0008e3689f

@coveralls
Copy link

coveralls commented Sep 27, 2024

Pull Request Test Coverage Report for Build 11076990468

Details

  • 21 of 25 (84.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 83.057%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/providers/instancetype/instancetype.go 21 25 84.0%
Totals Coverage Status
Change from base Build 11059083405: -0.03%
Covered Lines: 5554
Relevant Lines: 6687

💛 - Coveralls

njtran
njtran previously approved these changes Sep 27, 2024
@jmdeal jmdeal force-pushed the feat/filter-callback-itprov branch 2 times, most recently from 1554502 to 1eb97d5 Compare September 27, 2024 19:58
njtran
njtran previously approved these changes Sep 27, 2024
Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only nit: instanceFilterMap -> instanceTypeFilterMap

@jmdeal jmdeal force-pushed the feat/filter-callback-itprov branch from 76fc78d to ab4e7cf Compare September 27, 2024 20:03
@jmdeal jmdeal enabled auto-merge (squash) September 27, 2024 20:06
@jmdeal jmdeal merged commit 8676ebf into aws:main Sep 27, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants