Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update test to reduce create fleet payload size v0.36.x #7086

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

rschalo
Copy link
Contributor

@rschalo rschalo commented Sep 26, 2024

Fixes #N/A

Description
Fixes issue where create fleet calls can fail. This will only fail in the test suite due to filtering being done on the scheduler side, so it only affects standalone nodeclaims (which are unsupported).

How was this change tested?
E2Es.

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rschalo rschalo requested a review from a team as a code owner September 26, 2024 23:13
jmdeal
jmdeal previously approved these changes Sep 26, 2024
Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rschalo rschalo enabled auto-merge (squash) September 26, 2024 23:17
@rschalo rschalo disabled auto-merge September 26, 2024 23:19
@rschalo rschalo changed the title fix: update test to reduce create fleet payload size fix: update test to reduce create fleet payload size v0.36.x Sep 26, 2024
@jmdeal jmdeal force-pushed the constrain-node-claim-test-36 branch from f0343bd to dfab4e3 Compare September 26, 2024 23:21
Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rschalo rschalo enabled auto-merge (squash) September 26, 2024 23:23
@coveralls
Copy link

coveralls commented Sep 26, 2024

Pull Request Test Coverage Report for Build 11061729053

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.287%

Totals Coverage Status
Change from base Build 11044255949: 0.0%
Covered Lines: 5686
Relevant Lines: 7263

💛 - Coveralls

@rschalo rschalo merged commit 9a7a360 into aws:release-v0.36.x Sep 26, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants