Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add e2es and drop annotation on conversion v0.35.x #7074

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

rschalo
Copy link
Contributor

@rschalo rschalo commented Sep 25, 2024

Fixes #N/A

Description
Drops annotations from migrating resources in v1 versions.

How was this change tested?
E2E and unit testing.

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rschalo rschalo requested a review from a team as a code owner September 25, 2024 22:56
@rschalo rschalo requested a review from danxwang22 September 25, 2024 22:56
@coveralls
Copy link

coveralls commented Sep 25, 2024

Pull Request Test Coverage Report for Build 11042540253

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.5%) to 78.165%

Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.37%
Totals Coverage Status
Change from base Build 10932326923: 0.5%
Covered Lines: 5692
Relevant Lines: 7282

💛 - Coveralls

@rschalo rschalo changed the title chore: add e2es and drop annotation on conversion chore: add e2es and drop annotation on conversion v0.35.x Sep 25, 2024
Copy link
Contributor Author

@rschalo rschalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-6c2ed0f0d31bd7034e4c4021552311c805c55e84.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-6c2ed0f0d31bd7034e4c4021552311c805c55e84" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jmdeal jmdeal merged commit 8f8fafe into aws:release-v0.35.x Sep 26, 2024
20 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants