-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add cpu sustained clock speed label to instance metadata #7043
feat: add cpu sustained clock speed label to instance metadata #7043
Conversation
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks for your contribution! Running the test workflows. |
Pull Request Test Coverage Report for Build 11924912359Details
💛 - Coveralls |
@aidan-canva are you able to fix the CI errors? |
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
@njtran apologies for the delay, I've been on vacation for a period. I've just pushed a fix which should hopefully address the CI failures. Can I kick checks off myself? |
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
Without this feature it is very tricky to avoid the slow instance types like m5a which is 2.5Ghz while seemingly similar m5 is on 3.1Ghz, the difference is significant for many workloads. |
I'm still motivated to get this PR merged - I believe it was in a mergable stable 3 weeks ago and just waiting for a repo owner to trigger the CI checks. Since then, there are now some merge conflicts that need to be resolved (I can do that) - but it seems wasteful to do it and not get an indication someone can help get this merged. |
Hi @aidan-canva, apologies for the delay and timing. We're working on the next minor right now, think you could have this ready for review by Thursday morning and targeting merge Thursday EOD? Also, mind removing the instance type generation from the diff for this PR? We can do a fast-follow PR. |
@rschalo - No worries, I appreciate its a hectic time of year for most of AWS! I've just merged Should be ready for a CI run now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/karpenter snapshot
Snapshot successfully published to
|
Two tests failing from snapshot:
|
I looked at a few recently merged PR's and some of them also have these tests failing. Looks like a flake like you suggested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We'll need a fast-follow for the instance types and scheduling docs. Thanks again for the contribution!
Description
Some workloads are sensitive to variations instance CPU clock speed - either preferring a specific threshold or at least ensuring consistency across replicas. This PR adds the EC2
SustainedClockSpeedInGhz
value as a Karpenter label (karpenter.k8s.aws/instance-cpu-sustained-clock-speed-mhz
) so that workloads can add their preference.The upstream value from the EC2 API is in Ghz and represented as a float (ie 2.4). nodeSelectors only support ints or strings and most use-cases for this will want to leverage the
Gt
orLt
operators to set minimum/maximum values. To make this usable, this implementation converts the Ghz value into Mhz and represents it as an int.How was this change tested?
make test
Does this change impact docs?
Do codegen docs count?
website/content/en/preview/reference/instance-types.md
has been updated to reflect this new instance attribute.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.