Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Backport serviceNamespace for v1.0.x #6855

Merged
merged 1 commit into from
Aug 22, 2024
Merged

chore: Backport serviceNamespace for v1.0.x #6855

merged 1 commit into from
Aug 22, 2024

Conversation

engedaam
Copy link
Contributor

Fixes #N/A

Description

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner August 22, 2024 23:06
@engedaam engedaam requested review from njtran and removed request for a team August 22, 2024 23:06
jmdeal
jmdeal approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10516954935

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.341%
Totals Coverage Status
Change from base Build 10508438155: 0.0%
Covered Lines: 5922
Relevant Lines: 7464
💛 - Coveralls

@engedaam engedaam merged commit 62a726c into aws:release-v1.0.x Aug 22, 2024
12 checks passed
@engedaam engedaam deleted the bump-1.x branch August 22, 2024 23:13
@frimik frimik mentioned this pull request Sep 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmdeal jmdeal jmdeal approved these changes

@njtran njtran Awaiting requested review from njtran njtran is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@engedaam @coveralls @jmdeal @jonathan-innis