Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: "iam:PassRole" defined in CFN to work properly in AWS China #6839

Merged
merged 3 commits into from
Sep 3, 2024
Merged

fix: "iam:PassRole" defined in CFN to work properly in AWS China #6839

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b172a6
fix: "iam:PassRole" defined in CFN to work properly in AWS China
artem-nefedov Aug 22, 2024
910a4a4
Add url suffix template to all docs
jonathan-innis Aug 22, 2024
140f403
Use hardcoded list of services for "iam:PassedToService" condition
artem-nefedov Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion website/content/en/docs/getting-started/getting-started-with-karpenter/cloudformation.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ Resources:
"Action": "iam:PassRole",
"Condition": {
"StringEquals": {
"iam:PassedToService": "ec2.amazonaws.com"
"iam:PassedToService": "ec2.${AWS::URLSuffix}"
}
}
},
Expand Down
2 changes: 1 addition & 1 deletion website/content/en/docs/reference/cloudformation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ This gives EC2 permission explicit permission to use the `KarpenterNodeRole-${Cl
"Action": "iam:PassRole",
"Condition": {
"StringEquals": {
"iam:PassedToService": "ec2.amazonaws.com"
"iam:PassedToService": "ec2.${AWS::URLSuffix}"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion ...ite/content/en/preview/getting-started/getting-started-with-karpenter/cloudformation.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ Resources:
"Action": "iam:PassRole",
"Condition": {
"StringEquals": {
"iam:PassedToService": "ec2.amazonaws.com"
"iam:PassedToService": "ec2.${AWS::URLSuffix}"
}
}
},
Expand Down
2 changes: 1 addition & 1 deletion website/content/en/preview/reference/cloudformation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ This gives EC2 permission explicit permission to use the `KarpenterNodeRole-${Cl
"Action": "iam:PassRole",
"Condition": {
"StringEquals": {
"iam:PassedToService": "ec2.amazonaws.com"
"iam:PassedToService": "ec2.${AWS::URLSuffix}"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion website/content/en/v0.32/getting-started/getting-started-with-karpenter/cloudformation.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ Resources:
"Action": "iam:PassRole",
"Condition": {
"StringEquals": {
"iam:PassedToService": "ec2.amazonaws.com"
"iam:PassedToService": "ec2.${AWS::URLSuffix}"
}
}
},
Expand Down
2 changes: 1 addition & 1 deletion website/content/en/v0.32/reference/cloudformation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ This gives EC2 permission explicit permission to use the `KarpenterNodeRole-${Cl
"Action": "iam:PassRole",
"Condition": {
"StringEquals": {
"iam:PassedToService": "ec2.amazonaws.com"
"iam:PassedToService": "ec2.${AWS::URLSuffix}"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion website/content/en/v0.36/getting-started/getting-started-with-karpenter/cloudformation.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ Resources:
"Action": "iam:PassRole",
"Condition": {
"StringEquals": {
"iam:PassedToService": "ec2.amazonaws.com"
"iam:PassedToService": "ec2.${AWS::URLSuffix}"
}
}
},
Expand Down
2 changes: 1 addition & 1 deletion website/content/en/v0.36/reference/cloudformation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ This gives EC2 permission explicit permission to use the `KarpenterNodeRole-${Cl
"Action": "iam:PassRole",
"Condition": {
"StringEquals": {
"iam:PassedToService": "ec2.amazonaws.com"
"iam:PassedToService": "ec2.${AWS::URLSuffix}"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion website/content/en/v0.37/getting-started/getting-started-with-karpenter/cloudformation.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ Resources:
"Action": "iam:PassRole",
"Condition": {
"StringEquals": {
"iam:PassedToService": "ec2.amazonaws.com"
"iam:PassedToService": "ec2.${AWS::URLSuffix}"
}
}
},
Expand Down
2 changes: 1 addition & 1 deletion website/content/en/v0.37/reference/cloudformation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ This gives EC2 permission explicit permission to use the `KarpenterNodeRole-${Cl
"Action": "iam:PassRole",
"Condition": {
"StringEquals": {
"iam:PassedToService": "ec2.amazonaws.com"
"iam:PassedToService": "ec2.${AWS::URLSuffix}"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion website/content/en/v1.0/getting-started/getting-started-with-karpenter/cloudformation.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ Resources:
"Action": "iam:PassRole",
"Condition": {
"StringEquals": {
"iam:PassedToService": "ec2.amazonaws.com"
"iam:PassedToService": "ec2.${AWS::URLSuffix}"
}
}
},
Expand Down
2 changes: 1 addition & 1 deletion website/content/en/v1.0/reference/cloudformation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ This gives EC2 permission explicit permission to use the `KarpenterNodeRole-${Cl
"Action": "iam:PassRole",
"Condition": {
"StringEquals": {
"iam:PassedToService": "ec2.amazonaws.com"
"iam:PassedToService": "ec2.${AWS::URLSuffix}"
}
}
}
Expand Down
Loading