Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: right order to environment variable exports #6798

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

avielb-navina
Copy link
Contributor

Fixes #N/A

Description
the previous order was using variables before they were defined

How was this change tested?
with the preview tab

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

the previous order was using variables before they were defined
@avielb-navina avielb-navina requested a review from a team as a code owner August 19, 2024 08:16
@avielb-navina avielb-navina requested a review from rschalo August 19, 2024 08:16
Copy link

netlify bot commented Aug 19, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 0132164
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66c3aac01b761000080475ac
😎 Deploy Preview https://deploy-preview-6798--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jonathan-innis jonathan-innis force-pushed the patch-1 branch 3 times, most recently from 959f892 to b7bf193 Compare August 19, 2024 20:25
@coveralls
Copy link

coveralls commented Aug 19, 2024

Pull Request Test Coverage Report for Build 10460458599

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.264%

Totals Coverage Status
Change from base Build 10459345014: 0.0%
Covered Lines: 5921
Relevant Lines: 7470

💛 - Coveralls

@avielb-navina
Copy link
Contributor Author

hey!
please dont merge yet

Copy link
Contributor

@jigisha620 jigisha620 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit ca1bdc4 into aws:main Aug 19, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants