-
Notifications
You must be signed in to change notification settings - Fork 979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: clarify terminationGracePeriod #6783
Conversation
Clarify which terminationGracePeriod we are talking about. The page already talks about the pod's terminationGracePeriod so in this sentence it's not clear what terminationGradePeriod is referenced
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Co-authored-by: Jonathan Innis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Pull Request Test Coverage Report for Build 10484424711Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Clarify which terminationGracePeriod we are talking about. The page already talks about the pod's terminationGracePeriod so in this sentence it's not clear what terminationGradePeriod is referenced.
I assume this kind of change does not have to go to
preview/
.Fixes #N/A
Description
How was this change tested?
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.