Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify terminationGracePeriod #6783

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Conversation

ecerulm
Copy link
Contributor

@ecerulm ecerulm commented Aug 16, 2024

Clarify which terminationGracePeriod we are talking about. The page already talks about the pod's terminationGracePeriod so in this sentence it's not clear what terminationGradePeriod is referenced.

I assume this kind of change does not have to go to preview/.

Fixes #N/A

Description

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • [] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Clarify which terminationGracePeriod we are talking about. The page already talks about the pod's terminationGracePeriod so in this sentence it's not clear what terminationGradePeriod is referenced
@ecerulm ecerulm requested a review from a team as a code owner August 16, 2024 08:38
@ecerulm ecerulm requested a review from rschalo August 16, 2024 08:38
Copy link

netlify bot commented Aug 16, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 7ebe944
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66c58382072d710008421b8f
😎 Deploy Preview https://deploy-preview-6783--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ecerulm ecerulm changed the title docs: clarify ` docs: clarify terminationGracePeriod Aug 16, 2024
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis enabled auto-merge (squash) August 21, 2024 06:05
@coveralls
Copy link

coveralls commented Aug 21, 2024

Pull Request Test Coverage Report for Build 10484424711

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 79.303%

Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 91.67%
Totals Coverage Status
Change from base Build 10410267299: 0.03%
Covered Lines: 5935
Relevant Lines: 7484

💛 - Coveralls

@jonathan-innis jonathan-innis merged commit 28da0b9 into aws:main Aug 21, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants