Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add in Azure presence #6747

Merged
merged 4 commits into from
Aug 14, 2024
Merged

docs: Add in Azure presence #6747

merged 4 commits into from
Aug 14, 2024

Conversation

dtzar
Copy link
Contributor

@dtzar dtzar commented Aug 14, 2024

Related to kubernetes-sigs/karpenter#832

Description

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dtzar dtzar requested a review from a team as a code owner August 14, 2024 18:03
@dtzar dtzar requested a review from jigisha620 August 14, 2024 18:03
Copy link

netlify bot commented Aug 14, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 5dfa672
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66bd2ee2bcd5a70008e56adf
😎 Deploy Preview https://deploy-preview-6747--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dtzar dtzar force-pushed the azurepresence branch 2 times, most recently from a9a7046 to b7e44e8 Compare August 14, 2024 18:07
Copy link

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

njtran
njtran previously approved these changes Aug 14, 2024
jonathan-innis
jonathan-innis previously approved these changes Aug 14, 2024
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@njtran njtran enabled auto-merge (squash) August 14, 2024 22:45
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10395884927

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 79.341%

Totals Coverage Status
Change from base Build 10394763871: 0.01%
Covered Lines: 5922
Relevant Lines: 7464

💛 - Coveralls

@njtran njtran merged commit a70356a into aws:main Aug 14, 2024
16 checks passed
@dtzar dtzar deleted the azurepresence branch August 15, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants