Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add nodeclaim status validation for v1 on v0.33.x #6672

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Aug 7, 2024

Fixes #N/A

Description

  • Bump Karpenter version

How was this change tested?

  • /karpenter snapshot

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor Author

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@engedaam engedaam changed the title chore: Add nodeclaim status validation for v1 chore: Add nodeclaim status validation for v1 on v0.33.x Aug 7, 2024
Copy link
Contributor

github-actions bot commented Aug 7, 2024

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-568b1dc2c3caa900646319b39f4a00adf587532f.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-568b1dc2c3caa900646319b39f4a00adf587532f" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@engedaam engedaam marked this pull request as ready for review August 7, 2024 15:54
@engedaam engedaam requested a review from a team as a code owner August 7, 2024 15:54
@engedaam engedaam requested a review from tzneal August 7, 2024 15:54
@engedaam engedaam enabled auto-merge (squash) August 7, 2024 15:56
@coveralls
Copy link

coveralls commented Aug 7, 2024

Pull Request Test Coverage Report for Build 10287687577

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 77.118%

Totals Coverage Status
Change from base Build 10275913494: 0.0%
Covered Lines: 5261
Relevant Lines: 6822

💛 - Coveralls

@engedaam engedaam merged commit bae8b55 into aws:release-v0.33.x Aug 7, 2024
7 checks passed
@engedaam engedaam deleted the bump-version-33 branch August 8, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants