chore: Add v1 APIs and Conversion webhooks for v0.36.x #6621

engedaam · 2024-07-31T21:04:42Z

Fixes #N/A

Description

Add v1 APIs and the conversion webhooks
This is a copy and from main to release a patch version of 0.36

How was this change tested?

make presubmit

Does this change impact docs?

Yes, PR includes docs updates
Yes, issue opened: #
No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

coveralls · 2024-07-31T21:27:58Z

Pull Request Test Coverage Report for Build 10294998169

Details

256 of 718 (35.65%) changed or added relevant lines in 10 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-4.7%) to 77.631%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/apis/v1/ec2nodeclass_defaults.go	0	1	0.0%
pkg/apis/v1beta1/ec2nodeclass_conversion.go	0	2	0.0%
pkg/apis/v1/ec2nodeclass_conversion.go	184	190	96.84%
pkg/webhooks/webhooks.go	0	6	0.0%
pkg/apis/v1/ec2nodeclass_status.go	0	14	0.0%
pkg/apis/v1/ec2nodeclass.go	37	60	61.67%
pkg/apis/v1/zz_generated.deepcopy.go	0	410	0.0%

Files with Coverage Reduction	New Missed Lines	%
pkg/providers/amifamily/ami.go	1	90.43%
pkg/fake/utils.go	2	94.56%

Totals
Change from base Build 9133642145:	-4.7%
Covered Lines:	5598
Relevant Lines:	7211

💛 - Coveralls

engedaam

/karpenter snapshot

github-actions · 2024-07-31T21:45:04Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-71ce695cff5a6a3a956f05d88e77592abae7d312.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-71ce695cff5a6a3a956f05d88e77592abae7d312" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

engedaam

/karpenter snapshot

github-actions · 2024-08-03T14:46:19Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-4dc58344ad34642fa1269d3deb1dc66604d1225e.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-4dc58344ad34642fa1269d3deb1dc66604d1225e" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

engedaam

/karpenter snapshot

github-actions · 2024-08-06T06:36:59Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-30b93433cc57e547aa37eb7142e109a2b2850aa4.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-30b93433cc57e547aa37eb7142e109a2b2850aa4" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

engedaam

/karpenter snapshot

github-actions · 2024-08-06T07:44:29Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-a671e5afc7e528ad712e1a9916c7966bcab2378f.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-a671e5afc7e528ad712e1a9916c7966bcab2378f" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

jonathan-innis

LGTM 🚀

njtran

LGTM

jonathan-innis

LGTM 🚀

jonathan-innis

LGTM 🚀

engedaam force-pushed the add-webhook-36 branch from 6b50d90 to cf9990f Compare July 31, 2024 21:23

Add Conversion webhook

71ce695

engedaam force-pushed the add-webhook-36 branch from cf9990f to 71ce695 Compare July 31, 2024 21:24

engedaam commented Jul 31, 2024

View reviewed changes

engedaam force-pushed the add-webhook-36 branch 2 times, most recently from ca79a9f to 6f25a01 Compare August 2, 2024 14:56

Add post install hook

a04be71

engedaam force-pushed the add-webhook-36 branch 9 times, most recently from f3fff66 to 4dc5834 Compare August 3, 2024 13:47

engedaam commented Aug 3, 2024

View reviewed changes

engedaam force-pushed the add-webhook-36 branch from 4dc5834 to 722a4b2 Compare August 3, 2024 14:46

engedaam force-pushed the add-webhook-36 branch 5 times, most recently from 0cdd96c to 30b9343 Compare August 6, 2024 05:58

engedaam commented Aug 6, 2024

View reviewed changes

engedaam force-pushed the add-webhook-36 branch from 30b9343 to a671e5a Compare August 6, 2024 07:15

engedaam commented Aug 6, 2024

View reviewed changes

engedaam marked this pull request as ready for review August 6, 2024 15:06

engedaam requested a review from a team as a code owner August 6, 2024 15:06

engedaam requested a review from tzneal August 6, 2024 15:06

engedaam force-pushed the add-webhook-36 branch 3 times, most recently from 134e66c to 7b94ada Compare August 6, 2024 17:58

jonathan-innis previously approved these changes Aug 6, 2024

View reviewed changes

engedaam dismissed jonathan-innis’s stale review via 04124f2 August 6, 2024 19:17

engedaam force-pushed the add-webhook-36 branch 2 times, most recently from 04124f2 to 26bb83b Compare August 6, 2024 20:47

njtran previously approved these changes Aug 6, 2024

View reviewed changes

engedaam dismissed njtran’s stale review via 165c381 August 7, 2024 16:05

engedaam force-pushed the add-webhook-36 branch from 26bb83b to 165c381 Compare August 7, 2024 16:05

jonathan-innis previously approved these changes Aug 8, 2024

View reviewed changes

engedaam dismissed jonathan-innis’s stale review via 37a3c45 August 8, 2024 01:43

engedaam force-pushed the add-webhook-36 branch from 165c381 to 37a3c45 Compare August 8, 2024 01:43

Add templated crds for karpenter-crds

9c61c9f

engedaam force-pushed the add-webhook-36 branch from 37a3c45 to 9c61c9f Compare August 8, 2024 02:38

jonathan-innis approved these changes Aug 8, 2024

View reviewed changes

jonathan-innis merged commit ac671a8 into aws:release-v0.36.x Aug 8, 2024
13 checks passed

engedaam deleted the add-webhook-36 branch August 26, 2024 15:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Add v1 APIs and Conversion webhooks for v0.36.x #6621

chore: Add v1 APIs and Conversion webhooks for v0.36.x #6621

engedaam commented Jul 31, 2024

coveralls commented Jul 31, 2024 •

edited

Loading

engedaam left a comment

github-actions bot commented Jul 31, 2024

engedaam left a comment

github-actions bot commented Aug 3, 2024

engedaam left a comment

github-actions bot commented Aug 6, 2024

engedaam left a comment

github-actions bot commented Aug 6, 2024

jonathan-innis left a comment

njtran left a comment

jonathan-innis left a comment

jonathan-innis left a comment

chore: Add v1 APIs and Conversion webhooks for v0.36.x #6621

chore: Add v1 APIs and Conversion webhooks for v0.36.x #6621

Conversation

engedaam commented Jul 31, 2024

coveralls commented Jul 31, 2024 • edited Loading

Pull Request Test Coverage Report for Build 10294998169

Details

💛 - Coveralls

engedaam left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 31, 2024

engedaam left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 3, 2024

engedaam left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 6, 2024

engedaam left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 6, 2024

jonathan-innis left a comment

Choose a reason for hiding this comment

njtran left a comment

Choose a reason for hiding this comment

jonathan-innis left a comment

Choose a reason for hiding this comment

jonathan-innis left a comment

Choose a reason for hiding this comment

coveralls commented Jul 31, 2024 •

edited

Loading