Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add v1 RFC to the AWS CloudProvider repo #6604

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

jonathan-innis
Copy link
Contributor

Fixes #N/A

Description

Adds the AWS CloudProvider-specific v1 RFC to the aws/karpenter-provider-aws repo. This is an API and roadmap extension of the kubernetes-sigs/karpenter#1222 PR

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

netlify bot commented Jul 29, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit d0480b1
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66a8288ab287ac0008143794

Copy link

netlify bot commented Jul 29, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 27e24e7
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66a843c19c4ca000080e6c87
😎 Deploy Preview https://deploy-preview-6604--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Jul 29, 2024

Pull Request Test Coverage Report for Build 10154639380

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 79.119%

Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 91.67%
Totals Coverage Status
Change from base Build 10153036689: -0.01%
Covered Lines: 5926
Relevant Lines: 7490

💛 - Coveralls

@jonathan-innis jonathan-innis marked this pull request as ready for review July 30, 2024 01:24
@jonathan-innis jonathan-innis requested a review from a team as a code owner July 30, 2024 01:24
@jonathan-innis jonathan-innis requested a review from rschalo July 30, 2024 01:24
@jonathan-innis jonathan-innis enabled auto-merge (squash) July 30, 2024 01:24
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit

designs/v1-roadmap.md Outdated Show resolved Hide resolved
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit a5d5473 into aws:main Jul 30, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants