Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve bin-packing performance #652

Merged
merged 4 commits into from
Sep 1, 2021
Merged

improve bin-packing performance #652

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a6ee8d7
improve bin-packing performance
bwagner5 Aug 31, 2021
6a2d3e0
use must rather than should in comment
bwagner5 Aug 31, 2021
7815163
move node fullness check
bwagner5 Aug 31, 2021
03613d2
rename some things
bwagner5 Sep 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion pkg/controllers/allocation/binpacking/packable.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,13 +87,18 @@ func PackableFor(i cloudprovider.InstanceType) *Packable {

// Pack attempts to pack the pods into capacity, keeping track of previously
// packed pods. If the capacity cannot fit the pod, they are set aside.
// Pods must be sorted in descending order.
func (p *Packable) Pack(pods []*v1.Pod) *Result {
result := &Result{}
for _, pod := range pods {
for i, pod := range pods {
if ok := p.reservePod(pod); ok {
result.packed = append(result.packed, pod)
continue
}
if p.isFull(pods[len(pods)-1]) {
result.unpacked = append(result.unpacked, pods[i:]...)
return result
}
// if largest pod can't be packed, set it aside
if len(result.packed) == 0 {
result.unpacked = append(result.unpacked, pods...)
Expand All @@ -104,6 +109,20 @@ func (p *Packable) Pack(pods []*v1.Pod) *Result {
return result
}

// isFull checks if the reserved resources + the minimum resourced pod overflows the total resources available.
func (p *Packable) isFull(minPod *v1.Pod) bool {
bwagner5 marked this conversation as resolved.
Show resolved Hide resolved
minResourceList := resources.RequestsForPods(minPod)
for resourceName, totalQuantity := range p.total {
reservedQuantity := p.reserved[resourceName].DeepCopy()
// Add the minimum resourced pod to reserved
bwagner5 marked this conversation as resolved.
Show resolved Hide resolved
reservedQuantity.Add(minResourceList[resourceName])
if !totalQuantity.IsZero() && reservedQuantity.Cmp(totalQuantity) >= 0 {
return true
}
}
return false
}

func (p *Packable) reserve(requests v1.ResourceList) bool {
candidate := resources.Merge(p.reserved, requests)
// If any candidate resource exceeds total, fail to reserve
Expand Down
3 changes: 2 additions & 1 deletion pkg/controllers/allocation/binpacking/packer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,9 @@ func sortByResources(instanceTypes []cloudprovider.InstanceType) {
func weightOf(instanceType cloudprovider.InstanceType) float64 {
return euclidean(
float64(instanceType.CPU().Value()),
float64(instanceType.Memory().ScaledValue(resource.Mega)), // 1 gb = 1 cpu
float64(instanceType.Memory().ScaledValue(resource.Giga)), // 1 gb = 1 cpu
float64(instanceType.NvidiaGPUs().Value())*1000, // Heavily weigh gpus x 1000
float64(instanceType.AMDGPUs().Value())*1000, // Heavily weigh gpus x1000
float64(instanceType.AWSNeurons().Value())*1000, // Heavily weigh neurons x1000
)
}
Expand Down