Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Convert singleton reconcilers to operatorpkg #6310

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Jun 3, 2024

Fixes #N/A

Description

This updates our singleton controllers to use the singleton constructs in the operatorpkg package. This enables us to drop the implementation of the singleton builder that we currently have in Karpenter

How was this change tested?

make presubmit
/karpenter snapshot

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 462d20c
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6661168d649ae10008b27fb5

@jonathan-innis jonathan-innis force-pushed the convert-singleton branch 2 times, most recently from ab690e9 to 3dd56cf Compare June 3, 2024 07:46
@coveralls
Copy link

coveralls commented Jun 3, 2024

Pull Request Test Coverage Report for Build 9393873505

Details

  • 12 of 25 (48.0%) changed or added relevant lines in 4 files are covered.
  • 4 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.03%) to 82.474%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/nodeclaim/garbagecollection/controller.go 3 6 50.0%
pkg/controllers/providers/instancetype/controller.go 3 6 50.0%
pkg/controllers/providers/pricing/controller.go 3 6 50.0%
pkg/controllers/interruption/controller.go 3 7 42.86%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/providers/pricing/controller.go 1 77.78%
pkg/controllers/interruption/controller.go 1 72.83%
pkg/controllers/providers/instancetype/controller.go 1 60.71%
pkg/controllers/nodeclaim/garbagecollection/controller.go 1 71.88%
Totals Coverage Status
Change from base Build 9355595220: -0.03%
Covered Lines: 5553
Relevant Lines: 6733

💛 - Coveralls

Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

github-actions bot commented Jun 3, 2024

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-125464798d894b5006a6efb4807269a3fe48c84b.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-125464798d894b5006a6efb4807269a3fe48c84b" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

github-actions bot commented Jun 5, 2024

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-1ecb29fed5b495241e98e26000e9bedc319e5585.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-1ecb29fed5b495241e98e26000e9bedc319e5585" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@jonathan-innis jonathan-innis force-pushed the convert-singleton branch 2 times, most recently from f5fda0d to dcbb814 Compare June 5, 2024 18:10
@jonathan-innis jonathan-innis marked this pull request as ready for review June 6, 2024 01:53
@jonathan-innis jonathan-innis requested a review from a team as a code owner June 6, 2024 01:53
@jonathan-innis jonathan-innis requested a review from ljosyula June 6, 2024 01:53
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

github-actions bot commented Jun 6, 2024

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-462d20cd66687e4bc84b0862d330316d47244602.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-462d20cd66687e4bc84b0862d330316d47244602" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@jonathan-innis jonathan-innis enabled auto-merge (squash) June 7, 2024 02:25
Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit 69a8070 into aws:main Jun 7, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants