Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add note about eksctl breaking change #6276

Merged
merged 1 commit into from
May 28, 2024

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented May 28, 2024

Fixes #N/A

Description
Adds a note in the getting started guide about eksctl-io/eksctl#7775.

How was this change tested?
N/A

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner May 28, 2024 21:51
@jmdeal jmdeal requested a review from engedaam May 28, 2024 21:51
Copy link

netlify bot commented May 28, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 9c6561b
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66565443462102000836fc62
😎 Deploy Preview https://deploy-preview-6276--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

njtran
njtran previously approved these changes May 28, 2024
@coveralls
Copy link

coveralls commented May 28, 2024

Pull Request Test Coverage Report for Build 9276903394

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 82.55%

Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.56%
Totals Coverage Status
Change from base Build 9231904896: -0.02%
Covered Lines: 5549
Relevant Lines: 6722

💛 - Coveralls

@jmdeal jmdeal force-pushed the docs/eksctl-break branch from 021b46b to 9c6561b Compare May 28, 2024 22:01
@jmdeal jmdeal enabled auto-merge (squash) May 28, 2024 22:15
@jmdeal jmdeal merged commit 94283d2 into aws:main May 28, 2024
18 checks passed
@bryantbiggs
Copy link
Member

FYI - we got this patched in eksctl eksctl-io/eksctl#7775 (comment)

@jmdeal jmdeal deleted the docs/eksctl-break branch August 14, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants