add back TopologyManagerPolicy to bottlerocketsettings #6248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, no topology-manager-policy setting appears in instance userdata if it is set in EC2NodeClass userdata It seems like this setting was inadvertently removed in https://github.com/aws/karpenter-provider-aws/pull/3264/files#diff-a3cbfce28a0ecf65dea19fa09613d36dc9d5c653ff993472e70820de27f03efeL70
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Pull Request Test Coverage Report for Build 9167852758Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, no topology-manager-policy setting appears in instance userdata if it is set in EC2NodeClass userdata
It seems like this setting was inadvertently removed in https://github.com/aws/karpenter-provider-aws/pull/3264/files#diff-a3cbfce28a0ecf65dea19fa09613d36dc9d5c653ff993472e70820de27f03efeL70
Fixes #N/A
Description
How was this change tested?
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.