fix link to subnet tagging in development guide #623
Conversation
|
✔️ Deploy Preview for karpenter-docs-prod ready! 🔨 Explore the source changes: cd1e865 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/611ee3d7206053000706cce3 😎 Browse the preview: https://deploy-preview-623--karpenter-docs-prod.netlify.app |
| @@ -0,0 +1,49 @@ | |||
| --- | |||
| title: "Development Guide" | |||
There was a problem hiding this comment.
Can we call this Operational Requirements?
There was a problem hiding this comment.
Guessing you didn't mean to commit this.
There was a problem hiding this comment.
yes, this has been removed from the PR :)
| @@ -34,7 +34,7 @@ make delete # Uninstall Karpenter | |||
| * Make sure you have valid credentials to your development repository. | |||
| * `$KO_DOCKER_REPO` must point to your development repository | |||
| * Your cluster must have permissions to read from the repository | |||
| * If you created your cluster on version 1.19 or above, you may need to tag your subnets as mentioned [here](docs/aws/README.md). This is a temporary problem with our subnet discovery system, and is being tracked [here](https://github.com/awslabs/karpenter/issues/404#issuecomment-845283904). | |||
| * If you created your cluster on version 1.19 or above, you may need to tag your subnets as mentioned [here]({{< ref "{{< ref "/docs/getting-started/_index.md#tag-subnets" >}}" >}}). This is a temporary problem with our subnet discovery system, and is being tracked [here](https://github.com/awslabs/karpenter/issues/404#issuecomment-845283904). | |||
There was a problem hiding this comment.
Curious why you need a special ref. Don't markdown links work?
There was a problem hiding this comment.
I think it's necessary when you are using an "#" anchor on a "_index.md"
geoffcline
changed the title
geoffcline
force-pushed
the
patch-dev-guide-1
branch
from
aa81a77 to
d1aee15
Compare
geoffcline
force-pushed
the
patch-dev-guide-1
branch
from
d1aee15 to
a453958
Compare
|
sorry for the PR that should have been a draft 😅 it's better now |
Issue, if available:
in this guide https://karpenter.sh/docs/development-guide/ and the link embedded here (below) does not work:
Description of changes:
I changed the link to use a hugo reference, instead of linking to the old github content.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.