chore: add label and ability to schedule for az-id #6216

rschalo · 2024-05-16T23:01:28Z

Description
This change adds the az-id label to nodes and adds the ability to schedule against az-id.
How was this change tested?
Unit tests but I'm pretty certain an additional e2e test is required but want to get some feedback on implementation.

Does this change impact docs?

Yes, PR includes docs updates
Yes, issue opened: #
No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

netlify · 2024-05-16T23:01:43Z

✅ Deploy Preview for karpenter-docs-prod canceled.

Name	Link
🔨 Latest commit	`a5f78b1`
🔍 Latest deploy log	https://app.netlify.com/sites/karpenter-docs-prod/deploys/6650e37e7c3c07000862f4e4

go.mod

hack/validation/labels.sh

hack/validation/requirements.sh

coveralls · 2024-05-22T06:56:24Z

Pull Request Test Coverage Report for Build 9228695319

Details

105 of 114 (92.11%) changed or added relevant lines in 9 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.09%) to 82.52%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/fake/ec2api.go	4	8	50.0%
pkg/cloudprovider/cloudprovider.go	24	29	82.76%

Files with Coverage Reduction	New Missed Lines	%
pkg/fake/ec2api.go	1	86.89%

Totals
Change from base Build 9202817621:	0.09%
Covered Lines:	5547
Relevant Lines:	6722

💛 - Coveralls

jmdeal

/karpenter snapshot

github-actions · 2024-05-22T07:01:15Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-a7990602a49a8ae92fb1758e36186bb8c359fede.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-a7990602a49a8ae92fb1758e36186bb8c359fede" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

jmdeal

/karpenter snapshot

github-actions · 2024-05-22T16:04:57Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-30d7ffda0cfbbded65dec0fc7ce68b1ad034dd85.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-30d7ffda0cfbbded65dec0fc7ce68b1ad034dd85" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

pkg/providers/instance/instance.go

jmdeal

/karpenter snapshot

github-actions · 2024-05-22T23:15:29Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-739834ae1796b3ed662e8dde07506b00b75c5e70.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-739834ae1796b3ed662e8dde07506b00b75c5e70" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

pkg/apis/v1beta1/ec2nodeclass_status.go

pkg/apis/v1beta1/labels.go

pkg/cloudprovider/cloudprovider.go

pkg/cloudprovider/suite_test.go

pkg/providers/instance/instance.go

pkg/providers/instancetype/types.go

test/pkg/environment/aws/expectations.go

pkg/providers/subnet/subnet.go

test/suites/integration/scheduling_test.go

Co-authored-by: Jonathan Innis <[email protected]>

jmdeal

/karpenter snapshot

github-actions · 2024-05-24T09:07:30Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-5cbf5ad15a5905df275739b2738272883e5677bf.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-5cbf5ad15a5905df275739b2738272883e5677bf" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

jmdeal

/karpenter snapshot

github-actions · 2024-05-24T09:49:03Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-6ce84f41372594134c1aed313bf890a9b2e1e3a3.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-6ce84f41372594134c1aed313bf890a9b2e1e3a3" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

pkg/cloudprovider/cloudprovider.go

pkg/providers/instance/instance.go

pkg/providers/subnet/subnet.go

test/suites/integration/scheduling_test.go

njtran

/lgtm
/approve

rschalo commented May 16, 2024

View reviewed changes

go.mod Outdated Show resolved Hide resolved

rschalo force-pushed the add-az-id-label branch from 25d099c to 0f3a89d Compare May 22, 2024 00:32

jmdeal reviewed May 22, 2024

View reviewed changes

hack/validation/labels.sh Outdated Show resolved Hide resolved

hack/validation/requirements.sh Outdated Show resolved Hide resolved

jmdeal reviewed May 22, 2024

View reviewed changes

jmdeal force-pushed the add-az-id-label branch from 9c8b6f5 to 30d7ffd Compare May 22, 2024 16:01

jmdeal reviewed May 22, 2024

View reviewed changes

jmdeal force-pushed the add-az-id-label branch from 30d7ffd to bda6fae Compare May 22, 2024 16:08

jmdeal reviewed May 22, 2024

View reviewed changes

pkg/providers/instance/instance.go Outdated Show resolved Hide resolved

rschalo and others added 8 commits May 22, 2024 15:52

add ability to schedule on az-id

58e0ee8

middle of fixing unit tests, TODO: write e2etests

34a5476

deps (temp): pin to upstream PR

7949428

chore: misc functional fixes

f5ac78d

test: additional E2E tests

c376409

fix remaining tests

45a0c55

remove helper function refs

d61bb7b

temp: pin to upstream PR

f458a44

rschalo force-pushed the add-az-id-label branch from eb8373d to f458a44 Compare May 22, 2024 22:53

Merge branch 'main' into add-az-id-label

a5c0634

rschalo marked this pull request as ready for review May 22, 2024 23:04

rschalo requested a review from a team as a code owner May 22, 2024 23:04

rschalo requested a review from jonathan-innis May 22, 2024 23:04

fix ct check

739834a

jmdeal reviewed May 22, 2024

View reviewed changes

subnet test update

7d10fc8

jmdeal force-pushed the add-az-id-label branch from 911c6a5 to 7d10fc8 Compare May 23, 2024 00:30

jonathan-innis reviewed May 23, 2024

View reviewed changes

rschalo and others added 2 commits May 22, 2024 21:58

Update pkg/cloudprovider/suite_test.go

314e7ef

Co-authored-by: Jonathan Innis <[email protected]>

test: zone refactor

b9b9c55

jmdeal self-assigned this May 24, 2024

jmdeal added 3 commits May 24, 2024 00:01

remove subnet zone-id tracking

6a197d5

remaining PR feedback

758887b

Merge branch 'main' into add-az-id-label

c785ef9

jmdeal force-pushed the add-az-id-label branch from 334defe to 5cbf5ad Compare May 24, 2024 08:52

jmdeal reviewed May 24, 2024

View reviewed changes

jmdeal added 2 commits May 24, 2024 02:43

misc

c9ccd6a

deps: pin to upstream

6ce84f4

jmdeal force-pushed the add-az-id-label branch from 5cbf5ad to 6ce84f4 Compare May 24, 2024 09:43

jmdeal reviewed May 24, 2024

View reviewed changes

njtran reviewed May 24, 2024

View reviewed changes

jmdeal force-pushed the add-az-id-label branch 2 times, most recently from 579f71b to 5bc5be2 Compare May 24, 2024 18:56

remaining comments

a5f78b1

jmdeal force-pushed the add-az-id-label branch from 5bc5be2 to a5f78b1 Compare May 24, 2024 18:59

njtran reviewed May 24, 2024

View reviewed changes

njtran approved these changes May 24, 2024

View reviewed changes

jmdeal merged commit 8fa7793 into aws:main May 24, 2024
18 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: add label and ability to schedule for az-id #6216

chore: add label and ability to schedule for az-id #6216

rschalo commented May 16, 2024

netlify bot commented May 16, 2024 •

edited

Loading

coveralls commented May 22, 2024 •

edited

Loading

jmdeal left a comment

github-actions bot commented May 22, 2024

jmdeal left a comment

github-actions bot commented May 22, 2024

jmdeal left a comment

github-actions bot commented May 22, 2024

jmdeal left a comment

github-actions bot commented May 24, 2024

jmdeal left a comment

github-actions bot commented May 24, 2024

njtran left a comment

chore: add label and ability to schedule for az-id #6216

chore: add label and ability to schedule for az-id #6216

Conversation

rschalo commented May 16, 2024

netlify bot commented May 16, 2024 • edited Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

coveralls commented May 22, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9228695319

Details

💛 - Coveralls

jmdeal left a comment

Choose a reason for hiding this comment

github-actions bot commented May 22, 2024

jmdeal left a comment

Choose a reason for hiding this comment

github-actions bot commented May 22, 2024

jmdeal left a comment

Choose a reason for hiding this comment

github-actions bot commented May 22, 2024

jmdeal left a comment

Choose a reason for hiding this comment

github-actions bot commented May 24, 2024

jmdeal left a comment

Choose a reason for hiding this comment

github-actions bot commented May 24, 2024

njtran left a comment

Choose a reason for hiding this comment

netlify bot commented May 16, 2024 •

edited

Loading

coveralls commented May 22, 2024 •

edited

Loading