Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix status condition E2E check #6210

Merged
merged 1 commit into from
May 16, 2024

Conversation

jonathan-innis
Copy link
Contributor

Fixes #N/A

Description

Fixes status condition E2E check to validate message is set to empty

How was this change tested?

make presubmit
/karpenter snapshot

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner May 16, 2024 04:45
@jonathan-innis jonathan-innis requested a review from jigisha620 May 16, 2024 04:45
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@jonathan-innis jonathan-innis enabled auto-merge (squash) May 16, 2024 04:45
Copy link

netlify bot commented May 16, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit dce2ede
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66458f519d7fe700084bc07d

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9106612937

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 82.47%

Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.45%
Totals Coverage Status
Change from base Build 9106529156: -0.02%
Covered Lines: 5490
Relevant Lines: 6657

💛 - Coveralls

Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-dce2ede762a6756be7d65d5a63e1c1e0974fa2bf.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-dce2ede762a6756be7d65d5a63e1c1e0974fa2bf" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

Copy link
Contributor

@jigisha620 jigisha620 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathan-innis jonathan-innis merged commit 7d20e8d into aws:main May 16, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants