Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Auto generate and apply CRDs #6209

Merged
merged 3 commits into from
May 15, 2024
Merged

chore: Auto generate and apply CRDs #6209

merged 3 commits into from
May 15, 2024

Conversation

rschalo
Copy link
Contributor

@rschalo rschalo commented May 15, 2024

Fixes #N/A

Description
When using make apply to develop locally, auto generate and apply CRDs to latest specs.

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rschalo rschalo marked this pull request as ready for review May 15, 2024 19:09
@rschalo rschalo requested a review from a team as a code owner May 15, 2024 19:09
@rschalo rschalo requested a review from jonathan-innis May 15, 2024 19:09
@netlify Netlify
Copy link

netlify bot commented May 15, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 4b4b048
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6645088ecdcda20009d9b5e8

@rschalo rschalo enabled auto-merge (squash) May 15, 2024 19:11
@coveralls
Copy link

coveralls commented May 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9101366660

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.427%
Totals Coverage Status
Change from base Build 9099461397: 0.0%
Covered Lines: 5488
Relevant Lines: 6658
💛 - Coveralls

jonathan-innis
jonathan-innis approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rschalo rschalo merged commit aff1c1a into aws:main May 15, 2024
16 checks passed
@rschalo rschalo deleted the add-crd-apply branch May 17, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rschalo @coveralls @jonathan-innis