Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update golangci-lint config to latest #6196

Merged
merged 1 commit into from
May 14, 2024

Conversation

jonathan-innis
Copy link
Contributor

Fixes #N/A

Description

Update golangci-lint config to the latest, removing deprecating settings run.skip-dirs and govet.check-shadowing. This also enables more strict checking on govet

How was this change tested?

make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner May 14, 2024 03:14
@jonathan-innis jonathan-innis requested a review from ljosyula May 14, 2024 03:14
@jonathan-innis jonathan-innis enabled auto-merge (squash) May 14, 2024 03:14
Copy link

netlify bot commented May 14, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 28da60c
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6642d70d9f02900008689bc1

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9073182704

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 82.232%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/providers/instance/instance.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.43%
Totals Coverage Status
Change from base Build 9071538389: -0.02%
Covered Lines: 5438
Relevant Lines: 6613

💛 - Coveralls

Copy link
Contributor

@jigisha620 jigisha620 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathan-innis jonathan-innis merged commit 0cbf3e0 into aws:main May 14, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants