fix: Add truncating back to cloudprovider, considering minValues

[jonathan-innis]

Fixes #N/A

Description

This change adds an instanceTypes.Truncate() call back to the CloudProvider on 60 instance types. This will make no difference in the standard codepath since we already truncate in the scheduler but matters for cases when users launch standalone NodeClaims.

This should fix all failures in the NodeClaim suite in our VersionCompatability suite that run in eu-west-1. This test suite was failing consistently because we were sending too many instance types to EC2 Fleet, causing an error for too large of a response body to come back.

How was this change tested?

make presubmit
/karpenter snapshot
Running the NodeClaim suite on a local cluster in eu-west-1

Does this change impact docs?

• Yes, PR includes docs updates
• Yes, issue opened: #
• No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[netlify]

✅ Deploy Preview for karpenter-docs-prod canceled.

Name	Link
🔨 Latest commit	2d00dda
🔍 Latest deploy log	https://app.netlify.com/sites/karpenter-docs-prod/deploys/6646357e2ad3a600087e06b0

[jonathan-innis]

/karpenter snapshot

[github-actions]

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-efead7e583e0db60e888fc22808b7fffe708f98f.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-efead7e583e0db60e888fc22808b7fffe708f98f" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

[coveralls]

Pull Request Test Coverage Report for Build 9115947255

Details

• 2 of 4 (50.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.02%) to 82.45%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/providers/instance/instance.go	2	4	50.0%

Totals
Change from base Build 9114820850:	-0.02%
Covered Lines:	5492
Relevant Lines:	6661

---

💛 - Coveralls

[jonathan-innis]

/karpenter snapshot

[github-actions]

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-5da60db90ff4efe5bcace3d2d74baf4a8a1df51c.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-5da60db90ff4efe5bcace3d2d74baf4a8a1df51c" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

[jonathan-innis]

/karpenter snapshot

[github-actions]

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-2d00ddab7e96c38008641a282f69ef363e7a4d65.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-2d00ddab7e96c38008641a282f69ef363e7a4d65" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

[jmdeal]

LGTM 🚀