fix: Ensure shallow copy of data when returning back cached data

[jonathan-innis]

Fixes #N/A

Description

Ensure the slices are shallow copied before returning back cached data from the caller. This ensures if the slice of the data is manipulated by the caller (like sorted), it doesn't affect the original copy that is stored and cached.

This can particularly be a problem when sorts are occurring on the original data in a multi-threaded manner. Because of swaps, this can cause the same data to appear multiple times or to be altered in ways that are inconsistent.

How was this change tested?

make presubmit

Does this change impact docs?

• Yes, PR includes docs updates
• Yes, issue opened: #
• No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[netlify]

✅ Deploy Preview for karpenter-docs-prod canceled.

Name	Link
🔨 Latest commit	986794a
🔍 Latest deploy log	https://app.netlify.com/sites/karpenter-docs-prod/deploys/663e63d6bf6c7b0008c3950f

[coveralls]

Pull Request Test Coverage Report for Build 9036330896

Details

• 15 of 15 (100.0%) changed or added relevant lines in 4 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.04%) to 82.28%

---

Totals
Change from base Build 9034104269:	0.04%
Covered Lines:	5414
Relevant Lines:	6580

---

💛 - Coveralls

[njtran]

LGTM just two questions

[jonathan-innis]

/karpenter snapshot

[github-actions]

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-1af3a3741b049a596fce6359fb13dd1877a7d4ae.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-1af3a3741b049a596fce6359fb13dd1877a7d4ae" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

[vitaly-dt]

Hi @jonathan-innis
This fix has been communicated by AWS Health Dashboard as a critical fix.
Can you maybe elaborate on what is this pull request solving?