-
Notifications
You must be signed in to change notification settings - Fork 995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update associatePublicIPAddress
to not be set in the launch templets
#6159
Conversation
✅ Deploy Preview for karpenter-docs-prod canceled.
|
Pull Request Test Coverage Report for Build 9066372887Details
💛 - Coveralls |
9519450
to
1767740
Compare
9ca4f2f
to
279bc0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two optional nits
0eed484
to
dc899d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 Nice work!
… discover public ip association
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/karpenter snapshot
Snapshot successfully published to
|
Fixes #N/A
Description
associatePublicIPAddress
in their nodeclass, Karpenter would auto discover settingassociatePublicIPAddress
on launch templates by seeing if any of the subnets can add public IPs. If not, the field would be set tonil
on launch templates. After PR 6057, we would setassociatePublicIPAddress
to false in the launch template. This PR looks to make feature parity by settingassociatePublicIPAddress
on launch template tonil
.How was this change tested?
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.