Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update associatePublicIPAddress to not be set in the launch templets #6159

Merged
merged 1 commit into from
May 14, 2024

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented May 6, 2024

Fixes #N/A

Description

  • Before this change chore: Add an Subnet Controller to Asynchronously Hydrate Subnet Data #6057, If a customer did not set associatePublicIPAddress in their nodeclass, Karpenter would auto discover setting associatePublicIPAddress on launch templates by seeing if any of the subnets can add public IPs. If not, the field would be set to nil on launch templates. After PR 6057, we would set associatePublicIPAddress to false in the launch template. This PR looks to make feature parity by setting associatePublicIPAddress on launch template to nil.

How was this change tested?

  • N/A

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner May 6, 2024 17:12
@engedaam engedaam requested a review from ellistarn May 6, 2024 17:12
Copy link

netlify bot commented May 6, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 3fd6341
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66423e3b84d2a900084d6932

@coveralls
Copy link

coveralls commented May 6, 2024

Pull Request Test Coverage Report for Build 9066372887

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 82.292%

Totals Coverage Status
Change from base Build 9066218775: 0.01%
Covered Lines: 5414
Relevant Lines: 6579

💛 - Coveralls

@engedaam engedaam force-pushed the subnet-updates branch 4 times, most recently from 9519450 to 1767740 Compare May 12, 2024 01:00
@engedaam engedaam force-pushed the subnet-updates branch 3 times, most recently from 9ca4f2f to 279bc0a Compare May 13, 2024 02:12
jonathan-innis
jonathan-innis previously approved these changes May 13, 2024
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two optional nits

pkg/providers/subnet/suite_test.go Outdated Show resolved Hide resolved
pkg/providers/subnet/suite_test.go Outdated Show resolved Hide resolved
@engedaam engedaam force-pushed the subnet-updates branch 2 times, most recently from 0eed484 to dc899d5 Compare May 13, 2024 15:22
jonathan-innis
jonathan-innis previously approved these changes May 13, 2024
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Nice work!

njtran
njtran previously approved these changes May 13, 2024
@engedaam engedaam dismissed stale reviews from njtran and jonathan-innis via ed097c1 May 13, 2024 16:17
Copy link
Contributor Author

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-3fd6341378d14ffcaec3e153b201579dc4a9f977.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-3fd6341378d14ffcaec3e153b201579dc4a9f977" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@engedaam engedaam merged commit 47cc587 into aws:main May 14, 2024
29 checks passed
@engedaam engedaam deleted the subnet-updates branch May 14, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants