Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix docgen by calling providers directly #6138

Merged
merged 1 commit into from
May 3, 2024

Conversation

jonathan-innis
Copy link
Contributor

Fixes #N/A

Description

This change fixes calling make docgen and the instance types generation by calling the providers directly.

How was this change tested?

make docgen

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner May 3, 2024 07:27
@jonathan-innis jonathan-innis requested a review from rschalo May 3, 2024 07:27
Copy link

netlify bot commented May 3, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 0fa0778
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66349da3b0165000080cd776

@jonathan-innis jonathan-innis enabled auto-merge (squash) May 3, 2024 07:29
@coveralls
Copy link

coveralls commented May 3, 2024

Pull Request Test Coverage Report for Build 8936114830

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 82.232%

Totals Coverage Status
Change from base Build 8930965506: 0.05%
Covered Lines: 5401
Relevant Lines: 6568

💛 - Coveralls

Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit 35fe1c9 into aws:main May 3, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants