Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Find all of instance-profiles in the CI account #6137

Merged
merged 4 commits into from
May 24, 2024
Merged

ci: Find all of instance-profiles in the CI account #6137

merged 4 commits into from
May 24, 2024

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented May 3, 2024 •
edited
Loading

Fixes #N/A

Description

  • Instance-profiles API is paginated, and requires us to go through all the pages. This is causing to track and clean-up only the first page of instance-profiles. This PR will allow us to go though all the pages.

How was this change tested?

  • N/A

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner May 3, 2024 00:29
@engedaam engedaam requested a review from tzneal May 3, 2024 00:29
@netlify Netlify
Copy link

netlify bot commented May 3, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit b70dcf7
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6650fc3ad702050008994c3d

@engedaam engedaam changed the title chore: Find all pages of instance-profiles ci: Find all of instance-profiles in the CI account May 3, 2024
@coveralls
Copy link

coveralls commented May 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9229724752

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 82.52%
Totals Coverage Status
Change from base Build 9228795884: 0.02%
Covered Lines: 5547
Relevant Lines: 6722
💛 - Coveralls

@engedaam engedaam force-pushed the pageniate-instance-profile branch 4 times, most recently from c28f317 to ecdba4f Compare May 3, 2024 03:11
@engedaam engedaam force-pushed the pageniate-instance-profile branch from ecdba4f to 3b6bc84 Compare May 4, 2024 04:03
@github-actions GitHub Actions
Copy link
Contributor

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

@engedaam engedaam force-pushed the pageniate-instance-profile branch from c004320 to cb5d144 Compare May 24, 2024 20:12
@engedaam engedaam force-pushed the pageniate-instance-profile branch 3 times, most recently from 5460005 to c6dec4a Compare May 24, 2024 20:23
@engedaam engedaam closed this May 24, 2024
@engedaam engedaam force-pushed the pageniate-instance-profile branch from c6dec4a to 5944976 Compare May 24, 2024 20:25
@engedaam engedaam reopened this May 24, 2024
@engedaam engedaam force-pushed the pageniate-instance-profile branch from 9eca7fd to b70dcf7 Compare May 24, 2024 20:44
njtran
njtran approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jmdeal
jmdeal approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam merged commit 5c3dc15 into aws:main May 24, 2024
18 checks passed
@engedaam engedaam deleted the pageniate-instance-profile branch May 24, 2024 21:20
@engedaam engedaam mentioned this pull request Jun 3, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis left review comments

@jmdeal jmdeal jmdeal approved these changes

@njtran njtran njtran approved these changes

@tzneal tzneal Awaiting requested review from tzneal tzneal is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
lifecycle/stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@engedaam @coveralls @njtran @jmdeal @jonathan-innis