Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace ratelimiters with those from awslabs/operatorpkg #6134

Merged
merged 5 commits into from
May 2, 2024

Conversation

rschalo
Copy link
Contributor

@rschalo rschalo commented May 2, 2024

Fixes #N/A

Description
Utilizes https://github.com/awslabs/operatorpkg/blob/main/reasonable/reasonable.go
How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

netlify bot commented May 2, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 14569d1
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/663409babd6cb8000896192c

jonathan-innis
jonathan-innis previously approved these changes May 2, 2024
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rschalo rschalo marked this pull request as ready for review May 2, 2024 20:50
@rschalo rschalo requested a review from a team as a code owner May 2, 2024 20:50
@rschalo rschalo requested a review from ellistarn May 2, 2024 20:50
@coveralls
Copy link

coveralls commented May 2, 2024

Pull Request Test Coverage Report for Build 8930893926

Details

  • 0 of 3 (0.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 82.187%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/nodeclaim/tagging/controller.go 0 1 0.0%
pkg/controllers/nodeclass/hash/controller.go 0 1 0.0%
pkg/controllers/nodeclass/status/controller.go 0 1 0.0%
Totals Coverage Status
Change from base Build 8927066959: 0.1%
Covered Lines: 5403
Relevant Lines: 6574

💛 - Coveralls

ellistarn
ellistarn previously approved these changes May 2, 2024
Copy link
Contributor

@ellistarn ellistarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@rschalo rschalo dismissed stale reviews from ellistarn and jonathan-innis via 3703eb9 May 2, 2024 21:32
@rschalo rschalo force-pushed the replace-ratelimiters branch from e9888fb to 3703eb9 Compare May 2, 2024 21:32
@rschalo rschalo requested a review from jonathan-innis May 2, 2024 21:34
jonathan-innis
jonathan-innis previously approved these changes May 2, 2024
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rschalo rschalo enabled auto-merge (squash) May 2, 2024 21:47
@rschalo rschalo merged commit 6e36c24 into aws:main May 2, 2024
17 checks passed
@rschalo rschalo deleted the replace-ratelimiters branch May 3, 2024 01:40
jonathan-innis pushed a commit to jonathan-innis/karpenter-provider-aws that referenced this pull request May 3, 2024
jonathan-innis pushed a commit to jonathan-innis/karpenter-provider-aws that referenced this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants