Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix network bandwidth script and run codegen #6099

Merged
merged 1 commit into from
May 5, 2024
Merged

fix network bandwidth script and run codegen #6099

merged 1 commit into from
May 5, 2024

Conversation

jigisha620
Copy link
Contributor

Fixes #N/A

Description
The webpage that we used to get the network bandwidth information for different instance types is now changed. This PR updates the script to scrape those values to have the most updated set of instance types and their network bandwidths.

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jigisha620 jigisha620 requested a review from a team as a code owner April 25, 2024 18:25
@jigisha620 jigisha620 requested a review from engedaam April 25, 2024 18:25
@netlify Netlify
Copy link

netlify bot commented Apr 25, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit acd0a80
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/663408f5624d6d0008498502

@coveralls
Copy link

coveralls commented Apr 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8915632483

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.103%
Totals Coverage Status
Change from base Build 8914365316: 0.0%
Covered Lines: 5404
Relevant Lines: 6582
💛 - Coveralls

engedaam
engedaam reviewed Apr 26, 2024
View reviewed changes
hack/code/bandwidth_gen/main.go Show resolved Hide resolved
hack/code/bandwidth_gen/main.go Outdated Show resolved Hide resolved
hack/code/bandwidth_gen/main.go Outdated Show resolved Hide resolved
@jigisha620 jigisha620 force-pushed the feat-codegen branch 2 times, most recently from 2807815 to 27a78c9 Compare May 1, 2024 17:47
engedaam
engedaam previously approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

njtran
njtran approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jigisha620 jigisha620 merged commit bbdc07c into aws:main May 5, 2024
17 checks passed
@jonathan-innis jonathan-innis mentioned this pull request May 7, 2024
Closed
@matheuss matheuss mentioned this pull request Jul 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrocksunlee jrocksunlee jrocksunlee approved these changes

@njtran njtran njtran approved these changes

@engedaam engedaam engedaam left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jigisha620 @coveralls @njtran @engedaam @jrocksunlee