Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Clarify conceptual docs around Exists operator #6070

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

jonathan-innis
Copy link
Contributor

Fixes #6058

Description

Clarify some details around the Exists operator that caused confusion inside of the conceptual docs.

How was this change tested?

make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner April 21, 2024 21:58
@jonathan-innis jonathan-innis requested a review from engedaam April 21, 2024 21:58
Copy link

netlify bot commented Apr 21, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 3135a47
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6625a5c7ceeef80008056bb6
😎 Deploy Preview https://deploy-preview-6070--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Apr 21, 2024

Pull Request Test Coverage Report for Build 8776363486

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 81.963%

Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.32%
Totals Coverage Status
Change from base Build 8769944868: -0.02%
Covered Lines: 5394
Relevant Lines: 6581

💛 - Coveralls

@jonathan-innis jonathan-innis force-pushed the clarify-exists-operator branch 3 times, most recently from 0163b58 to 045be34 Compare April 21, 2024 23:47
@jonathan-innis jonathan-innis force-pushed the clarify-exists-operator branch from 045be34 to 3135a47 Compare April 21, 2024 23:48
@jonathan-innis jonathan-innis enabled auto-merge (squash) April 21, 2024 23:48
@Nuru
Copy link

Nuru commented Apr 21, 2024

@jonathan-innis Thank you for this clarification.

I still find the statement "you can isolate pods onto different nodes based on their values" a bit ambiguous with regard to pods that do not have node selectors/affinities. In the example given, you are assured that Team A pods and Team B pods are assigned different nodes, but you are not assured that other pods are not also assigned to those nodes, so the Team pods are not as isolated as one may desire.

How about changing the alert:

If a workload matches the NodePool but doesn't specify a label, Karpenter will generate a random label for the node.

To something like:

Note that by themselves, the node labels do not exclude workloads. If a workload matches the NodePool but doesn't specify a node selector or affinity, it can be assigned to any node, including the team-a or team-b nodes in the above example. If there is not an existing labeled node with capacity for the pod, Karpenter will launch a new node with a randomly generated value for the required label key.

Copy link
Contributor

@jigisha620 jigisha620 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathan-innis jonathan-innis merged commit 79fc601 into aws:main Apr 22, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better documentation for NodePool "Exists" operator
4 participants