Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move launch template managed tag #6051

Merged

Conversation

jonathan-innis
Copy link
Contributor

Fixes #N/A

Description

Move tag for managed launch templates to v1beta1 package

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner April 18, 2024 00:31
@jonathan-innis jonathan-innis requested a review from ljosyula April 18, 2024 00:31
@jonathan-innis jonathan-innis enabled auto-merge (squash) April 18, 2024 00:32
Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 59f5335
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66206dda2d953500083f5418

engedaam
engedaam previously approved these changes Apr 18, 2024
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8730672967

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 3 (33.33%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 82.031%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/providers/launchtemplate/launchtemplate.go 1 3 33.33%
Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.32%
Totals Coverage Status
Change from base Build 8713470070: 0.02%
Covered Lines: 5373
Relevant Lines: 6550

💛 - Coveralls

@jonathan-innis jonathan-innis merged commit 30baa2a into aws:main Apr 18, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants