-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Fix allow interruption queue actions #6048
Merged
jonathan-innis
merged 1 commit into
aws:release-v0.32.x
from
jonathan-innis:fix-allow-interruption-queue-actions
Apr 18, 2024
Merged
docs: Fix allow interruption queue actions #6048
jonathan-innis
merged 1 commit into
aws:release-v0.32.x
from
jonathan-innis:fix-allow-interruption-queue-actions
Apr 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jmdeal
previously approved these changes
Apr 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
jonathan-innis
force-pushed
the
fix-allow-interruption-queue-actions
branch
from
April 17, 2024 21:35
ad4b87a
to
128aa47
Compare
Pull Request Test Coverage Report for Build 8730696944Details
💛 - Coveralls |
jonathan-innis
force-pushed
the
fix-allow-interruption-queue-actions
branch
from
April 18, 2024 00:51
128aa47
to
15d8fa1
Compare
engedaam
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
johngmyers
pushed a commit
to johngmyers/karpenter
that referenced
this pull request
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5994
Description
Fixes the
release-v0.32.x
branch and its IAM policies onAllowInterruptionQueueActions
How was this change tested?
make presubmit
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.