Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix allow interruption queue actions #6048

Conversation

jonathan-innis
Copy link
Contributor

Fixes #5994

Description

Fixes the release-v0.32.x branch and its IAM policies on AllowInterruptionQueueActions

How was this change tested?

make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner April 17, 2024 01:37
@jonathan-innis jonathan-innis requested a review from njtran April 17, 2024 01:37
@jonathan-innis jonathan-innis changed the base branch from main to release-v0.32.x April 17, 2024 01:37
Copy link

netlify bot commented Apr 17, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit ad4b87a
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/661f27c084604c0008cdbdc9
😎 Deploy Preview https://deploy-preview-6048--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jmdeal
jmdeal previously approved these changes Apr 17, 2024
Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis enabled auto-merge (squash) April 17, 2024 20:42
@jonathan-innis jonathan-innis force-pushed the fix-allow-interruption-queue-actions branch from ad4b87a to 128aa47 Compare April 17, 2024 21:35
@coveralls
Copy link

coveralls commented Apr 17, 2024

Pull Request Test Coverage Report for Build 8730696944

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.486%

Totals Coverage Status
Change from base Build 8529198686: 0.0%
Covered Lines: 6259
Relevant Lines: 7588

💛 - Coveralls

Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit 656cf1e into aws:release-v0.32.x Apr 18, 2024
8 checks passed
johngmyers pushed a commit to johngmyers/karpenter that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IAM Policy in v1beta1 migration guide AWS_PARTITION template error
4 participants