Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Rate limiter for Hash and Status Controller #6043

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

engedaam
Copy link
Contributor

Fixes #N/A

Description

  • Adding rate limiter to make the stats and hash controller more consistent with the old NodeClass controller

How was this change tested?

  • N/A

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner April 16, 2024 00:58
@engedaam engedaam requested a review from jonathan-innis April 16, 2024 00:58
Copy link

netlify bot commented Apr 16, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 2e8de51
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/661dcd5558b17700084fcd65

@engedaam engedaam changed the title chore: Add rate limiter for hash and status Controller chore: Add Rate limiter for Hash and Status Controller Apr 16, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8698267946

Details

  • 0 of 16 (0.0%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.2%) to 82.0%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/nodeclass/hash/controller.go 0 8 0.0%
pkg/controllers/nodeclass/status/controller.go 0 8 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.32%
pkg/controllers/nodeclass/status/controller.go 1 70.18%
pkg/controllers/nodeclass/hash/controller.go 1 67.69%
Totals Coverage Status
Change from base Build 8698210108: -0.2%
Covered Lines: 5371
Relevant Lines: 6550

💛 - Coveralls

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam merged commit b64305c into aws:main Apr 16, 2024
17 checks passed
@engedaam engedaam deleted the add-rate-limiter branch April 16, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants