Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add a test for returning ec2nodeclass-hash-version on Create() #6031

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Apr 12, 2024

Fixes #N/A

Description

Add a test for returning ec2nodeclass-hash-version on Create()

How was this change tested?

make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner April 12, 2024 19:32
@jonathan-innis jonathan-innis requested a review from jmdeal April 12, 2024 19:32
@jonathan-innis jonathan-innis enabled auto-merge (squash) April 12, 2024 19:32
@jonathan-innis jonathan-innis changed the title test: Add a test for returning eksnodeclass-hash-version on Create() test: Add a test for returning ec2nodeclass-hash-version on Create() Apr 12, 2024
Copy link

netlify bot commented Apr 12, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 001b59e
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66198c3b0d11ac00082949a9

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8667064374

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.271%

Totals Coverage Status
Change from base Build 8666114838: 0.0%
Covered Lines: 5332
Relevant Lines: 6481

💛 - Coveralls

Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit c8e8dc9 into aws:main Apr 12, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants