Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Pinning Karpenter version for upgrade test suite #6030

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

jigisha620
Copy link
Contributor

Fixes #N/A

Description
Upgrade test suite is failing because it is trying to look for Karpenter snapshot that was deleted due to the cleanup policy.

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jigisha620 jigisha620 requested a review from a team as a code owner April 12, 2024 17:44
@jigisha620 jigisha620 requested a review from engedaam April 12, 2024 17:44
Copy link

netlify bot commented Apr 12, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit d652ea5
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/661975705f86cc00081878ee

@coveralls
Copy link

coveralls commented Apr 12, 2024

Pull Request Test Coverage Report for Build 8666042984

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 82.256%

Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.32%
pkg/fake/utils.go 2 94.56%
Totals Coverage Status
Change from base Build 8665243826: -0.05%
Covered Lines: 5331
Relevant Lines: 6481

💛 - Coveralls

@jigisha620 jigisha620 force-pushed the feat-fix-upgrade-suite branch from 9a3f3fa to d652ea5 Compare April 12, 2024 17:54
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jigisha620 jigisha620 enabled auto-merge (rebase) April 12, 2024 18:01
@jigisha620 jigisha620 merged commit c730713 into aws:main Apr 12, 2024
17 checks passed
@jigisha620 jigisha620 deleted the feat-fix-upgrade-suite branch April 24, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants