-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(chart): Updated release to not duplicate AH config #6022
fix(chart): Updated release to not duplicate AH config #6022
Conversation
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
42d7f77
to
23e5e99
Compare
23e5e99
to
44fee69
Compare
44fee69
to
9aab8df
Compare
Otherwise, changes look reasonable to me |
Pull Request Test Coverage Report for Build 8754972446Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Signed-off-by: Steve Hipwell <[email protected]>
9aab8df
to
5b83a09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
@stevehipwell Looks like the helm charts still have updated digests whenever they get pushed with the same tag. I haven't done a ton of looking but there's perhaps some work that we can do here to get a reproducible build so that the digest is always the same here. What do you think about creating an issue for reproducible builds for the helm charts as well as the AH config (by eventually finding a build flag to pass into the manifest file) so that we can track down those fixes eventually in our CI systems? |
@jonathan-innis do you mean the digest of the Helm chart created from the same raw files and uploaded with a For Karpenter you (probably) could manually implement the |
This partially reverts commit bc653f0.
Fixes #N/A
Description
This PR fixes the duplication of the Artifact Hub config file for each chart release resulting in the
artifacthub.io
tag having a new digest after each release. I've also added a README and fixed the CRDs chart config.There should be an untagged image for each chart release with AH config prior to the current release, these should be deleted unless there is an automated cleanup policy in place.
How was this change tested?
I switched to this pattern for my own Helm chart logic and have tested the logic there.
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.